Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main b 22777 ppm draft expense defect #14982

Merged
merged 7 commits into from
Mar 8, 2025

Conversation

brooklyn-welsh
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh commented Mar 7, 2025

Agility ticket

INT PR

#14885

Maria's Test Fix PR

#14969

Summary

~~Currently, if a customer creates an expense receipt during PPM closeout, but then deletes it before signing for the PPM closeout, the expense won't show up during document review on the SC side, but will show up on the AOA/SSW worksheet, which leads to incorrect payment amounts.

This branch adds a couple nil/status checks to ensure that these expenses are not added to the worksheet. The code now explicitly checks for an "APPROVED" status for all expenses.~~

Bug described above was actually fixed by a PR a day prior to this one being opened. After reviewing with other devs, this PR is instead intended to safeguard against a similar bug, where the if statement that was changed could still count deleted expenses if the status is somehow set back to NULL after going through the process (but not by deleting drafts as a customer, since this was fixed earlier)

Testing steps have been updated accordingly.

  1. Create a PPM move as a customer, approve as SC and go to "Upload PPM Documentation" as Customer
  2. Add expenses in the last section, they can be of any type, you'll want to make at least two. Keep track of the amounts of both/all of your expenses.
  3. As SC, approve the PPM closeout.
  4. As Customer, before you download your PPM packet, find the ID of one of your expenses in the moving_expenses table using either DBeaver or psql. Update its' status to NULL. Now download the payment packet, go to Page 2, and verify that the amounts in the "Claimed Expenses" section only show the amounts for the expense(s) you did not set to NULL.

Screenshots

Screenshot 2025-02-24 at 3 54 24 PM

@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review March 7, 2025 16:49
@brooklyn-welsh brooklyn-welsh requested a review from a team as a code owner March 7, 2025 16:49
@taeJungCaci taeJungCaci merged commit 91dc5e2 into main Mar 8, 2025
11 of 14 checks passed
@taeJungCaci taeJungCaci deleted the MAIN-B-22777-PPM-Draft-Expense-Defect branch March 8, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants