Main b 22777 ppm draft expense defect #14982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
INT PR
#14885
Maria's Test Fix PR
#14969
Summary
~~Currently, if a customer creates an expense receipt during PPM closeout, but then deletes it before signing for the PPM closeout, the expense won't show up during document review on the SC side, but will show up on the AOA/SSW worksheet, which leads to incorrect payment amounts.
This branch adds a couple nil/status checks to ensure that these expenses are not added to the worksheet. The code now explicitly checks for an "APPROVED" status for all expenses.~~
Bug described above was actually fixed by a PR a day prior to this one being opened. After reviewing with other devs, this PR is instead intended to safeguard against a similar bug, where the if statement that was changed could still count deleted expenses if the status is somehow set back to NULL after going through the process (but not by deleting drafts as a customer, since this was fixed earlier)
Testing steps have been updated accordingly.
Screenshots